add rotate and scale actions #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rexagod can I get a review here please :) See pr description for details. I updated the |
rexagod
approved these changes
Aug 2, 2019
|
Yay, thanks and great work! |
|
Shall we add this as an example to the README too? |
|
@jywarren It is already in README that you can add them as extra actions! |
|
@jywarren note that this PR restored the toolbar icon toggle on hotkey functionality, so we'll want to bump version # and connect to MK |
5 tasks
sashadev-sky
added a commit
that referenced
this pull request
Sep 15, 2019
* add rotate and scale actions * propgation wont fix * commit * commit * remove extra classnames * commit * remove extra comma
themacboy
pushed a commit
to themacboy/Leaflet.DistortableImage
that referenced
this pull request
Sep 19, 2019
* add rotate and scale actions * propgation wont fix * commit * commit * remove extra classnames * commit * remove extra comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
gruntIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
changes:
this pr allows the user to specify
RotateandScaleactions now in the actions array - they are not just only a keybinding now. But they are still not included in the default actions array.Bug Fix:in my pr Svg stack #353 I removed
showToolbarcalled after every action, but I have realized that now the action icons don't update on keypress, just icon click. This fixes that bug.I removed the
EnableEXIFfunction as a default action until we get it working via Incorporate EXIF functionality (and some refactors) #169