ci: test example building #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@prosemirror-adapter/core
@prosemirror-adapter/react
@prosemirror-adapter/lit
@prosemirror-adapter/solid
@prosemirror-adapter/vue
@prosemirror-adapter/svelte
commit: |
ocavue
force-pushed
the
ocavue/example-build
branch
from
671ce0a to
1563c4e
Compare
ocavue
commented
Dec 20, 2024
| @@ -0,0 +1 @@ | |||
| link-workspace-packages=deep | |||
There was a problem hiding this comment.
I need this so that pnpm -r run build can build packages first then build examples. Using "@prosemirror-adapter/lit": "workspace:*" in package.json can do this job too, but it won't allow stackblitz to open a sub directory like examples/lit and install dependencies.
|
@Saul-Mirone Could you review this? I removed .npmrc from .gitignore and I want to make you aware of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the
buildscript for all examples during CI pipeline. Thebuildscript for theexamples/sveltehas been broken for a while. This PR can prevent it from happening again.