-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UBNT AirOS module (older firmware) and other #1344
Open
v-zhuravlev
wants to merge
8
commits into
prometheus:main
Choose a base branch
from
grafana:modules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-zhuravlev
changed the title
Add UBNT AirOS module (older firmware)
Add UBNT AirOS module (older firmware) and Dlink switches
Jan 22, 2025
v-zhuravlev
changed the title
Add UBNT AirOS module (older firmware) and Dlink switches
Add UBNT AirOS module (older firmware) and Dlink, eltex switches
Jan 22, 2025
v-zhuravlev
changed the title
Add UBNT AirOS module (older firmware) and Dlink, eltex switches
Add UBNT AirOS module (older firmware) and Dlink
Jan 22, 2025
v-zhuravlev
changed the title
Add UBNT AirOS module (older firmware) and Dlink
Add UBNT AirOS module (older firmware) and other
Jan 22, 2025
SuperQ
requested changes
Jan 22, 2025
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
RichiH
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no other source, I think it's defensible
Signed-off-by: Sebastian Schubert <[email protected]>
bastischubert
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used for snmp-observ-lib(mixin) here:
https://github.com/grafana/jsonnet-libs/pull/1382/files#diff-d053bf7f667576c028f9c8a0b1ec7248b5963dcea3f9db7f87b8ddb75ede9a48R101
Sample response with CPU+mem:
Draft mixin example: https://github.com/grafana/jsonnet-libs/pull/1382/files#diff-b6afb60ecef31523e91401ffe4a3ad295af027e257e2d98fc9f0e9360084f3edR64
Sample response with CPU+mem:
mixin draft: https://github.com/grafana/jsonnet-libs/pull/1382/files#diff-d053bf7f667576c028f9c8a0b1ec7248b5963dcea3f9db7f87b8ddb75ede9a48R67