New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of DSN extra-argument handling. #484

Closed

nabadger wants to merge 1 commit into prometheus:master from nabadger:fix-dsn-arg-handling

nabadger commented Jun 26, 2020

I believe this addresses the following issues

DATA_SOURCE_NAME="my-user:my-password-with&?-chars@(127.0.0.1:3306)/ ./mysqld_exporter

This fix will just look for ? by checking only the chars that appear after the final / .

If there is no / in the DSN, then it's already being treated as an invalid DSN

invalid DSN: missing the slash separating the database name


          Fix handling of DSN extra-argument handling.

7a1024a

Author

nabadger commented Jun 26, 2020

Will re-open soon, messed something up...

nabadger closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet