Optimise handling of integers and floats for counters, gauges, summaries #176
+133
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Note too that gauges could take the value `undefined` to effectively block changes until explicitly set. This was implemented, but not tested, and in some edge-cases it would be buggy.
NelsonVides
force-pushed
the
integer_float_handling
branch
from
e90edef to
de0e1be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note too that gauges could take the value
undefinedto effectively block changes until explicitly set. This was implemented, but not tested, and in some edge-cases it would be buggy.Split from #173