Created Yoshi #1
Conversation
| let menuItemQA = MenuItem(name: "QA") | ||
| let environmentItems = [menuItemProd, menuItemStaging, menuItemQA].map { $0 as YoshiTableViewMenuItem } | ||
|
|
||
| let tableViewMenu = TableViewMenu(debugMenuName: "Environment", menuType: .TableView, displayItems: environmentItems, didSelectDisplayItem: { (displayItem) in |
There was a problem hiding this comment.
why do you need to specify the menu type when you use TableViewMenu? you should default here
There was a problem hiding this comment.
There are three different types of menu items
There was a problem hiding this comment.
Removed the type
There was a problem hiding this comment.
Yes but when you create a TableViewMenu the menu type should be defaulted to table view
MichaelCampbell
force-pushed
the
feature/create_pod
branch
from
9104ae7 to
5ec27a4
Compare
MichaelCampbell
force-pushed
the
feature/create_pod
branch
from
5ec27a4 to
6ee1213
Compare
| - parameter event: (UIEvent) the event captured by the original motionBegan call | ||
| - parameter minimumTouchRequirement: (Int) the minimum number of touches required to show the debug menu. | ||
| */ | ||
| public class func touchesBegan(touches: Set<UITouch>, withEvent event: UIEvent?, minimumTouchRequirement: Int = 3) { |
|
Any chance you can make it iOS 8 compliant? Or maybe in a next PR? |
|
just logged #2 @paulmiard. I'll take of this in the next PR. This one has already become pretty large |
MichaelCampbell
force-pushed
the
feature/create_pod
branch
from
a731565 to
f501a13
Compare
MichaelCampbell
force-pushed
the
feature/create_pod
branch
from
f501a13 to
3d8604c
Compare
Set iOS Deployment Target as 8.0 for Yoshi
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| self.setupDatePicker() |
There was a problem hiding this comment.
Should self be used here? I was under the impression that self was only really required within closures
Wait, the PiOS Swift Style guide still says
Use of self Please use self, even when it's not necessary, to make the property's owner obvious. (Note: this disagrees with the RW style guide)
https://bitbucket.org/prolificinteractive/pios/src/master/Coding%20Conventions/SwiftStyleGuide.md?fileviewer=file-view-default
There was a problem hiding this comment.
Don't use self.
Also don't use that style guide. It's out of date and has been moved: https://github.com/prolificinteractive/swift-style-guide
…wift style guide.
Updated the description and usage sections in the README.
Updated License
Updated Example project with debug check
Updated styling to match Prolific Swift Style Guide
|
👍 |
…ation Integrated SwiftLint
@quentinR @yoyoyoseob @htinlinn @paulmiard please review