Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more offline http tests #2276

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Adding more offline http tests #2276

merged 1 commit into from
Jul 11, 2022

Conversation

Mzack9999
Copy link
Member

Proposed changes

This PR adds the offline http tests mentioned in #2213

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. labels Jul 11, 2022
@Mzack9999 Mzack9999 self-assigned this Jul 11, 2022
@Mzack9999 Mzack9999 requested a review from ehsandeep July 11, 2022 19:35
@ehsandeep ehsandeep merged commit 57b2ec7 into dev Jul 11, 2022
@ehsandeep ehsandeep deleted the issue-2067-tests branch July 11, 2022 21:28
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mzack9999 @ehsandeep