Improving RFC request/response passive parsing #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Bug
Mzack9999
added
the
Status: Review Needed
Ice3man543
previously requested changes
Jun 21, 2022
There was a problem hiding this comment.
@Mzack9999 we should add a test case with a HTTP response that contains HTTP 1/1 placeholder in the response body so that we can validate the fix works.
4 tasks
Ice3man543
approved these changes
Jun 22, 2022
ehsandeep
approved these changes
Jul 11, 2022
ehsandeep
added
Status: Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a check in the passive parsing helper function that tries to parse passive request/response with the standard library, before switching to placeholder matching.
Checklist
Notes
In this particular case the parsing still fails due to a bug in
proxifyrelated to request body length miscalculation (ref projectdiscovery/proxify#135)