Set DrainconnectionsOnHostRemoval to true for any cluster w/healthchecks #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th checks enabled Signed-off-by: Steve Sloka <[email protected]>
|
/hold I need to test this quickly to validate that it actually does what it says. |
|
@stevesloka it would be great if you could write an e2e test for this, taking the ingressroute from #603 and checking that contour emits the right envoy data structure. |
|
Milestone removed, please re-add the 0.10 milestone when this PR is ready. Thanks. |
|
👍 I'll get those e2e's in, thanks! |
Closed
|
@stevesloka i'm going to merge this fix for 0.10. I've opened #926 to track the missing test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603 by setting DrainConnectionsOnHostRemoval to true if the cluster has healthchecks enabled.
//cc projectcontour/gimbal#208
Signed-off-by: Steve Sloka [email protected]