Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connect on Http2ProtocolOptions when Websockets are enabled #6846

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rajatvig
Copy link
Member

@rajatvig rajatvig commented Jan 12, 2025

This should possibly address part of #3371 and possibly knative/serving#13083 when using Knative with Contour.

Signed-off-by: Rajat Vig [email protected]

@rajatvig rajatvig added the release-note/small A small change that needs one line of explanation in the release notes. label Jan 12, 2025
Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (6f6c0f4) to head (0da4d80).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6846   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files         133      133           
  Lines       20026    20030    +4     
=======================================
+ Hits        16232    16236    +4     
  Misses       3500     3500           
  Partials      294      294           
Files with missing lines Coverage Δ
internal/envoy/v3/listener.go 98.50% <100.00%> (+<0.01%) ⬆️

@rajatvig rajatvig marked this pull request as ready for review January 12, 2025 01:25
@rajatvig rajatvig requested a review from a team as a code owner January 12, 2025 01:25
@rajatvig rajatvig requested review from tsaarni and sunjayBhatia and removed request for a team January 12, 2025 01:25
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and clayton-gonsalves and removed request for a team January 12, 2025 01:26
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant