-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace labeling for tenant owners #423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFedotov
force-pushed
the
issues/407
branch
from
September 15, 2021 16:20
43de92d
to
8925f5c
Compare
prometherion
requested changes
Sep 15, 2021
MaxFedotov
force-pushed
the
issues/407
branch
3 times, most recently
from
September 16, 2021 19:29
7ddf572
to
74013fa
Compare
@prometherion oh yes, finally all green :) waiting for a review! |
MaxFedotov
force-pushed
the
issues/407
branch
2 times, most recently
from
September 17, 2021 16:10
17ad4f7
to
53b0f73
Compare
MaxFedotov
force-pushed
the
issues/407
branch
from
September 22, 2021 07:58
53b0f73
to
77b3143
Compare
rebased on a newest master |
prometherion
requested changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the missing on Helm Chart version bump up.
prometherion
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #407
@prometherion will add documentation tomorrow :)