feat: fix quota overprovisioning #1333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEt's face our biggest problem #49
This approach mainly prevents updates to resourceQuotas via MutatingWebhook. It always patches to the Hard Spec what's left in the tenant and updates the status on the tenant. Since this happens in parallel, no overflow should be possible anymore.
Have not yet tested, what happens, when we migrate from namespaces which have already overprovisioned. I also need to implement when a quota item is deleted, that the status is restructured. It's a bit difficult, since i can only go off indices