Add sempahore auto go-build workflow #9589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
radTuti
reviewed
Dec 12, 2024
| @@ -338,6 +338,31 @@ define update_replace_pin | |||
| fi' | |||
| endef | |||
|
|
|||
| # Get the latest release tag from projectcalico/go-build. | |||
| GO_BUILD_REPO=https://github.com/projectcalico/go-build.git | |||
| define get_go_build_version | |||
There was a problem hiding this comment.
i think this should give the option for a specific version based on go version.
while on master it is fine to get the latest, as we create new branches, they should go based on their go version?
There was a problem hiding this comment.
This auto pin update is only planned for the master branch. This is triggered by calico/go-build after a successful tag build. It requires more detailed definition in calico/go-build to make branch auto pin update work properly.
hjiawei
force-pushed
the
add-auto-go-build-workflow
branch
from
eb4bd2c to
02aa686
Compare
hjiawei
force-pushed
the
add-auto-go-build-workflow
branch
from
02aa686 to
6430830
Compare
hjiawei
added
docs-not-required
This change adds a semaphore workflow to trigger calico/go-build pin update. We improved calico/go-build to trigger this workflow when there is a new release tag pushed to the go-build repository.
hjiawei
force-pushed
the
add-auto-go-build-workflow
branch
from
6430830 to
c17173f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a semaphore workflow to trigger calico/go-build pin update. We improved calico/go-build to trigger this workflow when there is a new release tag pushed to the go-build repository.
Related issues/PRs
Requires changes from projectcalico/go-build#611.
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.