fix(sync): fixed harbor authentication issues on _catalog endpoint #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
fix_sync_harbor
branch
from
5a22a14 to
02cce1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
- Coverage 91.90% 91.88% -0.03%
==========================================
Files 170 170
Lines 30291 30300 +9
==========================================
+ Hits 27839 27841 +2
- Misses 1825 1830 +5
- Partials 627 629 +2 ☔ View full report in Codecov by Sentry. |
andaaron
reviewed
Jan 19, 2025
| @@ -174,4 +174,5 @@ var ( | |||
| ErrInvalidSearchQuery = errors.New("invalid search query") | |||
| ErrImageNotFound = errors.New("image not found") | |||
| ErrAmbiguousInput = errors.New("input is not specific enough") | |||
| ErrUnexpectedAuthHeader = errors.New("expected bearer auth header, received basic") | |||
There was a problem hiding this comment.
The string does not match the variable name exactly. How about having a more generic string here, and wrapping the error adding the specifics of 'bearer'/basic' in the code where it is used?
|
Tested on Harbor 2.12.2 - works fine, both onDemand true and false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.