Add Random to the counterpick CSS in ranked #6
Conversation
There was a problem hiding this comment.
I would also change the places where CKIND_GANONDORF is being used and replace with a new constant CKIND_LAST_INDEX or similar so you dont have to replace all the places on the code, just change the value of the constant.
As it is right now it makes it hard to scale as too many changes are needed in different places.
Components/CharPickerDialog.c
Outdated
| @@ -30,6 +34,9 @@ static void _InputsThink(GOBJ *gobj) { | |||
|
|
|||
| if (downInputs & HSD_BUTTON_A) { | |||
| SFX_PlayCommon(CommonSound_ACCEPT); // Play "accept" sound | |||
| if (cpd->state.char_selection_idx == 26) { // Select random | |||
There was a problem hiding this comment.
@walz0 same as the previous comment but this would be a different named constant, something like CKIND_RANDOM
There was a problem hiding this comment.
should be much more scalable / readable now, i added constants for random and last index and refactored every instance where i used CKIND_GANONDORF +1 or 26
|
@JLaferri bumping this for possible merge since its been approved for a while |
Adds a CSIcon with the Question material to the CharPickerDialog. Uses HSD_Randi to select a random character and proceeds with the normal character confirm logic.