-
Notifications
You must be signed in to change notification settings - Fork 9
Fix validation against amber provenance #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for the late reply
@@ -31,11 +31,10 @@ go_library( | |||
|
|||
go_test( | |||
name = "verifier_test", | |||
size = "enormous", | |||
size = "small", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice change :)
) | ||
|
||
//go:embed schema/v1/provenance.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I didn't know about this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know about it either, before this PR. It was very exciting to discover it and see it work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review :)
) | ||
|
||
//go:embed schema/v1/provenance.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know about it either, before this PR. It was very exciting to discover it and see it work :)
Fixes #127
Fixes tests and the dependency to the schema for the amber provenances.