Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Fix validation against amber provenance #143

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

rbehjati
Copy link
Contributor

Fixes #127

Fixes tests and the dependency to the schema for the amber provenances.

@rbehjati rbehjati changed the title Fix tests Fix validation against amber provenance Oct 18, 2022
@rbehjati rbehjati requested a review from tiziano88 October 18, 2022 22:42
Copy link

@tiziano88 tiziano88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the late reply

@@ -31,11 +31,10 @@ go_library(

go_test(
name = "verifier_test",
size = "enormous",
size = "small",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change :)

)

//go:embed schema/v1/provenance.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't know about this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know about it either, before this PR. It was very exciting to discover it and see it work :)

Copy link
Contributor Author

@rbehjati rbehjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review :)

)

//go:embed schema/v1/provenance.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know about it either, before this PR. It was very exciting to discover it and see it work :)

@rbehjati rbehjati merged commit 838ea59 into project-oak:main Oct 20, 2022
@rbehjati rbehjati deleted the fix-tests branch October 20, 2022 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix validation against amber provenance schema and cleanup the tests
2 participants