Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Fix validation against amber provenance schema and cleanup the tests #127

Closed
rbehjati opened this issue Sep 14, 2022 · 1 comment · Fixed by #143
Closed

Fix validation against amber provenance schema and cleanup the tests #127

rbehjati opened this issue Sep 14, 2022 · 1 comment · Fixed by #143
Assignees

Comments

@rbehjati
Copy link
Contributor

Why does the path need to be restored? Does it mean that it affects the execution of other test cases? That would seem problematic, since the execution of the tests would differ whether they are running concurrently or not. Is it possible to make the entire process not depend on the PWD and instead use absolute paths for everything? It would still be possible here to concat PWD with a relative path to obtain an absolute path and use that, but at least that would not mutate global state.

Originally posted by @tiziano88 in #124 (comment)

@rbehjati
Copy link
Contributor Author

We are planning to fully switch to the generic SLSA provenance format. Once that is done this problem will probably automatically go away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant