Skip to content

Commit

Permalink
Fix missing changes
Browse files Browse the repository at this point in the history
The previous commit was merged before being synced up to HEAD, missing
some needing changes.

Change-Id: I8315b00d6a1b73aa9c4c30032fa881b7e95a8524
  • Loading branch information
jblebrun committed Feb 21, 2025
1 parent b49a2f4 commit 5122264
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cc/oak_session/client_server_session_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ SessionConfig* TestConfigUnattestedNKServer(
bindings::IdentityKey* identity_key) {
return SessionConfigBuilder(AttestationType::kUnattested,
HandshakeType::kNoiseNK)
.SetSelfPrivateKey(identity_key)
.SetSelfStaticPrivateKey(identity_key)
.Build();
}

Expand All @@ -117,7 +117,7 @@ SessionConfig* TestConfigUnattestedKK(absl::string_view peer_public_key,
return SessionConfigBuilder(AttestationType::kUnattested,
HandshakeType::kNoiseKK)
.SetPeerStaticPublicKey(peer_public_key)
.SetSelfPrivateKey(self_private_key)
.SetSelfStaticPrivateKey(self_private_key)
.Build();
}

Expand Down
5 changes: 3 additions & 2 deletions cc/oak_session/config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,10 @@ SessionConfigBuilder SessionConfigBuilder::AddSessionBinder(
return *this;
}

SessionConfigBuilder SessionConfigBuilder::SetSelfPrivateKey(
SessionConfigBuilder SessionConfigBuilder::SetSelfStaticPrivateKey(
bindings::IdentityKey* signing_key) {
builder_ = session_config_builder_set_self_private_key(builder_, signing_key);
builder_ =
session_config_builder_set_self_static_private_key(builder_, signing_key);
return *this;
}

Expand Down
3 changes: 2 additions & 1 deletion cc/oak_session/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ class SessionConfigBuilder {
absl::string_view attester_id, bindings::FfiAttestationVerifier attester);
SessionConfigBuilder AddSessionBinder(absl::string_view attester_id,
bindings::SigningKey* binding_key);
SessionConfigBuilder SetSelfPrivateKey(bindings::IdentityKey* signing_key);
SessionConfigBuilder SetSelfStaticPrivateKey(
bindings::IdentityKey* signing_key);
SessionConfigBuilder SetPeerStaticPublicKey(absl::string_view public_key);

private:
Expand Down

0 comments on commit 5122264

Please sign in to comment.