Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCL-7207] Implement Build Config create/edit page - Build parameters section #354

Merged
merged 6 commits into from
Jan 23, 2024
Merged

[NCL-7207] Implement Build Config create/edit page - Build parameters section #354

merged 6 commits into from
Jan 23, 2024

Conversation

patrikk0123
Copy link
Contributor

No description provided.

@patrikk0123 patrikk0123 requested a review from matedo1 December 7, 2023 16:26
@patrikk0123 patrikk0123 force-pushed the ncl7207-buildConfigCreateEditPage-buildParams branch from 218cc73 to 395c8a7 Compare December 8, 2023 09:54
@matedo1 matedo1 added the m label Dec 8, 2023
matedo1
matedo1 reviewed Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@matedo1 matedo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are discussing this PR on PM.

@patrikk0123 patrikk0123 force-pushed the ncl7207-buildConfigCreateEditPage-buildParams branch from 395c8a7 to b1b660b Compare December 14, 2023 14:06
@patrikk0123 patrikk0123 removed the m label Dec 15, 2023
@DnsZhou DnsZhou added the m label Jan 4, 2024
@matedo1
Copy link
Collaborator

matedo1 commented Jan 10, 2024

We are discussing this PR on PM.

@patrikk0123 patrikk0123 force-pushed the ncl7207-buildConfigCreateEditPage-buildParams branch from b1b660b to 7fa053f Compare January 15, 2024 16:56
@patrikk0123 patrikk0123 requested a review from matedo1 January 15, 2024 16:56
matedo1
matedo1 requested changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@matedo1 matedo1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I found some bugs (see jira comment)
  • Let's discuss useEffect in useForm.ts

@patrikk0123 patrikk0123 force-pushed the ncl7207-buildConfigCreateEditPage-buildParams branch from 7fa053f to c83e550 Compare January 16, 2024 12:12
@patrikk0123 patrikk0123 force-pushed the ncl7207-buildConfigCreateEditPage-buildParams branch from c83e550 to d9dcf0a Compare January 23, 2024 09:48
@patrikk0123 patrikk0123 requested a review from matedo1 January 23, 2024 09:48
@patrikk0123 patrikk0123 force-pushed the ncl7207-buildConfigCreateEditPage-buildParams branch from d9dcf0a to 6d84783 Compare January 23, 2024 10:37
@patrikk0123 patrikk0123 force-pushed the ncl7207-buildConfigCreateEditPage-buildParams branch from 6d84783 to 0df12e3 Compare January 23, 2024 13:10
@patrikk0123 patrikk0123 merged commit d02339c into project-ncl:main Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matedo1 matedo1 matedo1 approved these changes

Assignees

@matedo1 matedo1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrikk0123 @matedo1 @DnsZhou