Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NCL-7205] Implement Revision tab of Build Config Details #349

Closed

Conversation

DnsZhou
Copy link
Contributor

@DnsZhou DnsZhou commented Nov 29, 2023

No description provided.

@matedo1 matedo1 removed their request for review November 29, 2023 07:59
@DnsZhou DnsZhou force-pushed the ncl7205-buildConfigDetailsRevisionTab branch from ea5a448 to 2f26117 Compare December 6, 2023 05:10
@DnsZhou DnsZhou added the p label Dec 6, 2023
@DnsZhou DnsZhou marked this pull request as draft January 2, 2024 02:44
@DnsZhou DnsZhou force-pushed the ncl7205-buildConfigDetailsRevisionTab branch 3 times, most recently from ee4132f to 36cbf52 Compare January 17, 2024 07:27
@DnsZhou DnsZhou marked this pull request as ready for review January 17, 2024 07:27
@DnsZhou
Copy link
Contributor Author

DnsZhou commented Jan 17, 2024

Hi @patrikk0123 , this pr is ready for review now. Thanks

@DnsZhou DnsZhou force-pushed the ncl7205-buildConfigDetailsRevisionTab branch 3 times, most recently from 2da6e5f to c615329 Compare January 18, 2024 12:14
@matedo1
Copy link
Collaborator

matedo1 commented Jan 18, 2024

I tested it locally and summarized individual issues in jira

@DnsZhou DnsZhou force-pushed the ncl7205-buildConfigDetailsRevisionTab branch from c615329 to 6ff57d2 Compare January 18, 2024 15:34
@DnsZhou DnsZhou force-pushed the ncl7205-buildConfigDetailsRevisionTab branch from 6ff57d2 to 8b04320 Compare January 18, 2024 15:42
@DnsZhou DnsZhou removed the p label Jan 30, 2024
@matedo1 matedo1 self-requested a review February 15, 2024 09:56
@matedo1
Copy link
Collaborator

matedo1 commented Feb 15, 2024

Approved by mistake, this PR is replaced by #390

@matedo1 matedo1 closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants