Aggregator Code Bug Fixes & Example In Go Code #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove reference to activity.Context.GetSharedTempData() Add a sharedData map to aggregator activity Implement StructValue interface for Input and Output structs.
|
@n-is do you mind signing the CLA so we can merge your PR? Thanks! |
fm-tibco
reviewed
Oct 25, 2019
| @@ -83,7 +86,7 @@ func (a *Activity) Metadata() *activity.Metadata { | |||
| // Eval implements api.Activity.Eval - Aggregates the Message | |||
| func (a *Activity) Eval(ctx activity.Context) (done bool, err error) { | |||
|
|
|||
| sharedData := ctx.GetSharedTempData() | |||
| sharedData := a.sharedData | |||
There was a problem hiding this comment.
ctx.GetSharedTempData() should work. Do you have the panic that this causes?
This call should end up in state.go#107 which should create a map if one doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
activity.Context.GetSharedTempData()because it returnsnil, foractivityContext, according to the flogo-project/core apisharedDatamap to theaggregateactivity, so there is nopanicat runtime due tonilmapStructValueinterface for theInputandOutputstructs in aggregator codeaggregatein go code.