Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(game/sounds): release sound ids #1078

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

lukealford
Copy link
Contributor

Pull Request Description

Bug

FiveM has a limit of about 100 active soundIDs, if you don't correctly release a soundID you end up with a -1 ID which ends up muting any native sounds, even native sounds outside the scope of this resource(e.g. police sirens).

Solution

Correctly release sounds IDs after use or before creating a new one.

I've also included the same fix from #1027

Pull Request Checklist:

  • Have you followed the guidelines in our Contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you built and tested NPWD in-game after the relevant change?

@itschip itschip merged commit c24374e into project-error:master Oct 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants