fix(game/sounds): release sound ids #1078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Bug
FiveM has a limit of about 100 active soundIDs, if you don't correctly release a soundID you end up with a -1 ID which ends up muting any native sounds, even native sounds outside the scope of this resource(e.g. police sirens).
Solution
Correctly release sounds IDs after use or before creating a new one.
I've also included the same fix from #1027
Pull Request Checklist: