Skip to content

Commit

Permalink
ipatests: fix test_caless.py
Browse files Browse the repository at this point in the history
Commit e3f3584 introduced an additional prompt in ipa-server-install
"Do you want to configure chrony with NTP server or pool address?".

The test is building a string passed to stdin in interactive mode
but this string has not been updated with the additional answer for
this new question.

This commit answers 'no' to the question and allows to proceed with
the ipa server installation.

Fixes: https://pagure.io/freeipa/issue/7969
Reviewed-By: Tibor Dudlak <[email protected]>
  • Loading branch information
flo-renaud authored and Tiboris committed Jun 10, 2019
1 parent cef4edd commit 07f7e3e
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions ipatests/test_integration/test_caless.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def get_install_stdin(cert_passwords=()):
]
lines.extend(cert_passwords) # Enter foo.p12 unlock password
lines += [
'no', # configure chrony with NTP server or pool address?
'yes', # Continue with these values?
]
return '\n'.join(lines + [''])
Expand Down Expand Up @@ -1357,24 +1358,18 @@ def test_ds_bad_usage(self):
'The server certificate in server.p12 is not valid: {err}'
.format(err=BAD_USAGE_MSG))

@pytest.mark.xfail(reason='freeipa ticket 7759', strict=True)
def test_http_intermediate_ca(self):
"Install new HTTP certificate issued by intermediate CA"

result = self.certinstall('w', 'ca1/subca/server')
# As the intermediate CA is not trusted, command must fail
assert_error(result,
"Peer's certificate issuer is not trusted")
assert result.returncode == 0, result.stderr_text

@pytest.mark.xfail(reason='freeipa ticket 6959', strict=True)
def test_ds_intermediate_ca(self):
"Install new DS certificate issued by intermediate CA"

result = self.certinstall('d', 'ca1/subca/server')
# As the intermediate CA is not trusted, command must fail
assert_error(result,
"Peer's certificate issuer is not trusted "
"(certutil: certificate is invalid: Peer's Certificate "
"issuer is not recognized.")
assert result.returncode == 0, result.stderr_text

def test_self_signed(self):
"Install new self-signed certificate"
Expand Down

0 comments on commit 07f7e3e

Please sign in to comment.