ipatests: fix expected output for ipahealthcheck.meta.services

ipa-healthcheck commit 31be12b introduced a change in the output message when pki-tomcatd is not running. With versions <= 0.12, the service name is displayed as pki_tomcatd (with an underscore), but with 0.13+ it is pki-tomcatd (with a dash). Fixes: https://pagure.io/freeipa/issue/9460 Signed-off-by: Florence Blanc-Renaud <[email protected]> Reviewed-By: Rob Crittenden <[email protected]>
progier389 · Nov 13, 2023 · 07e5637 · 07e5637
1 parent caccd6c
commit 07e5637
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py
@@ -454,6 +454,11 @@ def test_source_ipahealthcheck_meta_services_check(self, restart_service):
             assert data[0]["result"] == "SUCCESS"
             assert data[0]["kw"]["status"] is True
 
+        version = tasks.get_healthcheck_version(self.master)
+        # With healthcheck newer versions, the error msg for PKI tomcat
+        # contains the string pki-tomcatd instead of pki_tomcatd
+        always_replace = parse_version(version) >= parse_version("0.13")
+
         for service in svc_list:
             restart_service(self.master, service)
             returncode, data = run_healthcheck(
@@ -466,7 +471,7 @@ def test_source_ipahealthcheck_meta_services_check(self, restart_service):
             for check in data:
                 if check["check"] != service:
                     continue
-                if service != 'pki_tomcatd':
+                if service != 'pki_tomcatd' or always_replace:
                     service = service.replace('_', '-')
                 assert check["result"] == "ERROR"
                 assert check["kw"]["msg"] == "%s: not running" % service