Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/to id failing with zero #42

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix/to id failing with zero #42

merged 2 commits into from
Oct 30, 2023

Conversation

felipebergamin
Copy link
Member

Description

TypeIdDataSource.toId is throwing Invalid typename error when id value is zero

Related Issues

Progress

Pull request checklist

  • Tests: This PR includes tests for covering the features or bug fixes (if applicable).
  • Docs: This PR updates/creates the necessary documentation.
  • CI: Make sure your Pull Request passes all CI checks. If not, clarify the motif behind that and the action plan to solve it (may reference a ticket)

How to test it

Visual reference

@felipebergamin
fix(type-id-datasource): toId throwing error for zero
a20d164 
TypeIdDataSource.toId was failing for zero IDs
This commit changes the implementation to accept zero value
@felipebergamin
4.0.2
4392df3
@felipebergamin felipebergamin merged commit 4392df3 into master Oct 30, 2023
2 checks passed
@felipebergamin felipebergamin deleted the fix/to-id-failing-with-zero branch October 30, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDDKnightmare DDDKnightmare DDDKnightmare approved these changes

@YasminBeatriz YasminBeatriz YasminBeatriz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipebergamin @YasminBeatriz @DDDKnightmare