Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ad-hoc): Edge-to-edge dialog #261

Merged
merged 5 commits into from
Feb 7, 2025
Merged

fix(ad-hoc): Edge-to-edge dialog #261

merged 5 commits into from
Feb 7, 2025

Conversation

vitalii-vanziak-cko
Copy link
Collaborator

Description

  • Workaround to enable edge-to-edge for Compose dialog. Note: scrim still doesn't cover status bar on some Android versions, but it always covers navigation bar and fixes enter transition glitch, which overall looks good.
  • Custom enter animation.

Bug:

dialog_bug.webm

Fixed:

dialog_fixed.webm

@vitalii-vanziak-cko vitalii-vanziak-cko merged commit d3b723f into master Feb 7, 2025
1 check passed
@vitalii-vanziak-cko vitalii-vanziak-cko deleted the fix/ad-hoc/dialog branch February 7, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-vysotskyi-cko andrii-vysotskyi-cko andrii-vysotskyi-cko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitalii-vanziak-cko @andrii-vysotskyi-cko