Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(POM-447): (Dynamic Checkout) Delete saved payment methods #255

Merged
merged 95 commits into from
Jan 30, 2025
Merged

feat(POM-447): (Dynamic Checkout) Delete saved payment methods #255

merged 95 commits into from
Jan 30, 2025

Conversation

vitalii-vanziak-cko
Copy link
Collaborator

@vitalii-vanziak-cko vitalii-vanziak-cko commented Jan 29, 2025 •
edited
Loading

Description

  • Standalone SavedPaymentMethods screen (so far closed by ProcessOutInternalApi annotation).
  • Integration of SavedPaymentMethods screen to Dynamic Checkout.

Added:

  • deleteCustomerToken API bindings.
  • Idempotency-Key header for PUT and DELETE requests (in addition to POST ).
  • POButton composable variant that incapsulates confirmation dialog.
  • trailingContent to POHeader, it allows to add Cancel (X) button.
  • Localization strings.

Refactored:

  • New PODrawableImage with POImageRenderingMode applied to all buttons on all screens and respective configurations.
  • Configuration change for all screens: SubmitButton renamed to generic reusable Button, when certain button needs additional features it will get it's own name (like CancelButton).
  • Deprecated inner Options configuration of nAPM (Compose) and Card Update in favor of inline properties. Related refactoring to stop using Options internally.
  • Dynamic checkout view model state, updated UI.

Misc:
Compose 2025.01.01

dc_delete_saved_methods.mp4
dc_delete_dialog.webm

Jira Issue

https://checkout.atlassian.net/browse/POM-447

@vitalii-vanziak-cko
Fix example app
91ce51d
@vitalii-vanziak-cko
'customer_id' and 'removing_allowed'
96384e5
@vitalii-vanziak-cko
Extract CLIENT_SECRET to HeaderConstants
489c0de
@vitalii-vanziak-cko
deleteCustomerToken() api method
64e90ab
@vitalii-vanziak-cko
Update KDoc
f995d0b
@vitalii-vanziak-cko
deleteCustomerToken() in repository and service
2c0eeaf
@vitalii-vanziak-cko
Activity, bottom sheet, configuration, contract, launcher
14881ba
@vitalii-vanziak-cko
SavedPaymentMethodsEvent
baca753
@vitalii-vanziak-cko
SavedPaymentMethodsInteractorState
37fe104
@vitalii-vanziak-cko
SavedPaymentMethodsViewModelState
435d7da
@vitalii-vanziak-cko
VM update
065a46f
@vitalii-vanziak-cko
SavedPaymentMethodsInteractor
0986e32
@vitalii-vanziak-cko
SavedPaymentMethodsViewModel
a854691
@vitalii-vanziak-cko
Init VM
56fb616
@vitalii-vanziak-cko
Handle completion and activity result
593ac88
@vitalii-vanziak-cko
Apply screenModeAsState()
67e834c
@vitalii-vanziak-cko
Error message
c2b1dc2
@vitalii-vanziak-cko
Code format
7971072
@vitalii-vanziak-cko
Basic screen and style
92b5dfd
@vitalii-vanziak-cko
Add Idempotency-Key on PUT and DELETE
dfa8b91
@vitalii-vanziak-cko
deleting_allowed
29b463d
@vitalii-vanziak-cko
Screens startup configuration validation
2c6210e
@vitalii-vanziak-cko
po_dynamic_checkout_express_checkout (string)
4412a14
@vitalii-vanziak-cko
Localizations
49ad8d4
@vitalii-vanziak-cko
Delete Confirmation strings
c400aab
@vitalii-vanziak-cko
icons
a6821bf
@vitalii-vanziak-cko
confirmationDialogStyle in POActionsContainer
521691f
@vitalii-vanziak-cko
ActionKey -> ActionId
3f7af44
@vitalii-vanziak-cko
Update POActionsContainer params
02726dd
@vitalii-vanziak-cko
New POButton composable function that incapsulates confirmation dialog
39b44b2
@vitalii-vanziak-cko
Empty view and style
4e194a0
@vitalii-vanziak-cko
Fetch and map payment methods, preload all images
dda8400
@vitalii-vanziak-cko
borderColor on DC
1ff268e
@vitalii-vanziak-cko
PaymentMethod's UI
f7bb9bc
@vitalii-vanziak-cko
Empty view paddings
f74bc5d
@vitalii-vanziak-cko
Added processing state to delete action
82ce581
@vitalii-vanziak-cko
POButton.ProgressIndicatorSize Small/Medium
5497213
@vitalii-vanziak-cko
Delete customer token
efb3f9f
@vitalii-vanziak-cko
Reformat VM
34974a1
@vitalii-vanziak-cko
Fix crossfade
727ea12
@vitalii-vanziak-cko
Fix transition animation
b13a6b4
@vitalii-vanziak-cko
po_saved_payment_methods_error_generic
e5715fd
@vitalii-vanziak-cko
Error handling
49a02d9
@vitalii-vanziak-cko
Delete payment method from interactor state
4ea0b76
@vitalii-vanziak-cko
POSavedPaymentMethodsEvent and POSavedPaymentMethodsDelegate
a09dba2
@vitalii-vanziak-cko
Dispatch events to delegate in launcher
a4989ca
@vitalii-vanziak-cko
deleteLocalCustomerToken() on DC
2b70f80
@vitalii-vanziak-cko
Disable express settings button while processing payment
45b94ab
@vitalii-vanziak-cko
Fullscreen SavedPaymentMethodsBottomSheet
c2d1e00
@vitalii-vanziak-cko
Propagate POSavedPaymentMethodsEvent via PODynamicCheckoutDelegate
3144fd8
@vitalii-vanziak-cko
dispatchSavedPaymentMethodsConfiguration() via DC launcher
b5f668c
@vitalii-vanziak-cko
Allow to alter POSavedPaymentMethodsConfiguration on DC
af69a33
@vitalii-vanziak-cko
Keep express settings button always enabled
1775962
@vitalii-vanziak-cko
Compose 2025.01.01
25e0039
@vitalii-vanziak-cko
Update DC config in example app
079c0a1
@vitalii-vanziak-cko vitalii-vanziak-cko marked this pull request as ready for review January 30, 2025 10:45
@vitalii-vanziak-cko vitalii-vanziak-cko merged commit 7b33eb9 into master Jan 30, 2025
1 check passed
@vitalii-vanziak-cko vitalii-vanziak-cko deleted the feat/POM-447/dc-delete-saved-methods branch January 30, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-vysotskyi-cko andrii-vysotskyi-cko andrii-vysotskyi-cko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitalii-vanziak-cko @andrii-vysotskyi-cko