Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: internally store more data of event definitions #2923

Merged
merged 2 commits into from
Oct 13, 2023
Merged

refactor: internally store more data of event definitions #2923

merged 2 commits into from
Oct 13, 2023

Conversation

csouchet
Copy link
Member

Before, we only internally stored the id, kind and the number of occurrences of a kind.

For the link events, we need more data, like source and target.

Covers #2855

@csouchet csouchet added the enhancement New feature or request label Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

♻️ PR Preview 11aa92b has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

♻️ PR Preview 11aa92b has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet mentioned this pull request Oct 12, 2023
Merged
@csouchet csouchet marked this pull request as ready for review October 12, 2023 15:23
@csouchet csouchet requested a review from tbouffard October 12, 2023 15:23
@tbouffard tbouffard changed the title feat(event definition): internally store more data of event definitions feat: internally store more data of event definitions Oct 12, 2023
@tbouffard tbouffard added refactoring Code refactoring and removed enhancement New feature or request labels Oct 12, 2023
@tbouffard tbouffard changed the title feat: internally store more data of event definitions refactor: internally store more data of event definitions Oct 12, 2023
tbouffard
tbouffard approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ All checks pass
ℹ️ new feature using this refactoring will be implemented with #2924

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tbouffard tbouffard merged commit 7fc889d into master Oct 13, 2023
@tbouffard tbouffard deleted the 2855-Store_the_whole_event_definition_object branch October 13, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard