Further relax HMC inference test tolerance. #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhlmueller
added a commit
that referenced
this pull request
Feb 24, 2016
Further relax HMC inference test tolerance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #350:
Across multiple tests, the distribution of the mean looks pretty sensible. The tolerances were too low before, but at 0.075 the tolerance (for the mean of nestedEnum5) is roughly 4 SD of the empirical distribution. I ran the test 5K times and only saw one test failure, which seems about right if we assume the distribution is Gaussian. I've bumped it up a little further (~4.5 SD) to give us more room. Sound OK?