Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @openzeppelin/contracts from 4.9.5 to 5.0.2 #981

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 10, 2024

Bumps @openzeppelin/contracts from 4.9.5 to 5.0.1.

Release notes

Sourced from @​openzeppelin/contracts's releases.

v5.0.1

  • ERC2771Context and Context: Introduce a _contextPrefixLength() getter, used to trim extra information appended to msg.data.
  • Multicall: Make aware of non-canonical context (i.e. msg.sender is not _msgSender()), allowing compatibility with ERC2771Context.

v5.0.0

Additions Summary

The following contracts and libraries were added:

  • AccessManager: A consolidated system for managing access control in complex systems.
    • AccessManaged: A module for connecting a contract to an authority in charge of its access control.
    • GovernorTimelockAccess: An adapter for time-locking governance proposals using an AccessManager.
    • AuthorityUtils: A library of utilities for interacting with authority contracts.
  • GovernorStorage: A Governor module that stores proposal details in storage.
  • ERC2771Forwarder: An ERC2771 forwarder for meta transactions.
  • ERC1967Utils: A library with ERC1967 events, errors and getters.
  • Nonces: An abstraction for managing account nonces.
  • MessageHashUtils: A library for producing digests for ECDSA operations.
  • Time: A library with helpers for manipulating time-related objects.

Removals Summary

The following contracts, libraries, and functions were removed:

  • Address.isContract (because of its ambiguous nature and potential for misuse)
  • Checkpoints.History
  • Counters
  • ERC20Snapshot
  • ERC20VotesComp
  • ERC165Storage (in favor of inheritance based approach)
  • ERC777
  • ERC1820Implementer
  • GovernorVotesComp
  • GovernorProposalThreshold (deprecated since 4.4)
  • PaymentSplitter
  • PullPayment
  • SafeMath
  • SignedSafeMath
  • Timers
  • TokenTimelock (in favor of VestingWallet)
  • All escrow contracts (Escrow, ConditionalEscrow and RefundEscrow)
  • All cross-chain contracts, including AccessControlCrossChain and all the vendored bridge interfaces
  • All presets in favor of OpenZeppelin Contracts Wizard

These removals were implemented in the following PRs: #3637, #3880, #3945, #4258, #4276, #4289

Changes by category

General

... (truncated)

Changelog

Sourced from @​openzeppelin/contracts's changelog.

5.0.1 (2023-12-07)

  • ERC2771Context and Context: Introduce a _contextPrefixLength() getter, used to trim extra information appended to msg.data.
  • Multicall: Make aware of non-canonical context (i.e. msg.sender is not _msgSender()), allowing compatibility with ERC2771Context.

5.0.0 (2023-10-05)

Additions Summary

The following contracts and libraries were added:

  • AccessManager: A consolidated system for managing access control in complex systems.
    • AccessManaged: A module for connecting a contract to an authority in charge of its access control.
    • GovernorTimelockAccess: An adapter for time-locking governance proposals using an AccessManager.
    • AuthorityUtils: A library of utilities for interacting with authority contracts.
  • GovernorStorage: A Governor module that stores proposal details in storage.
  • ERC2771Forwarder: An ERC2771 forwarder for meta transactions.
  • ERC1967Utils: A library with ERC1967 events, errors and getters.
  • Nonces: An abstraction for managing account nonces.
  • MessageHashUtils: A library for producing digests for ECDSA operations.
  • Time: A library with helpers for manipulating time-related objects.

Removals Summary

The following contracts, libraries, and functions were removed:

  • Address.isContract (because of its ambiguous nature and potential for misuse)
  • Checkpoints.History
  • Counters
  • ERC20Snapshot
  • ERC20VotesComp
  • ERC165Storage (in favor of inheritance based approach)
  • ERC777
  • ERC1820Implementer
  • GovernorVotesComp
  • GovernorProposalThreshold (deprecated since 4.4)
  • PaymentSplitter
  • PullPayment
  • SafeMath
  • SignedSafeMath
  • Timers
  • TokenTimelock (in favor of VestingWallet)
  • All escrow contracts (Escrow, ConditionalEscrow and RefundEscrow)
  • All cross-chain contracts, including AccessControlCrossChain and all the vendored bridge interfaces
  • All presets in favor of OpenZeppelin Contracts Wizard

These removals were implemented in the following PRs: #3637, #3880, #3945, #4258, #4276, #4289

Changes by category

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 10, 2024
@dependabot dependabot bot requested a review from 0xmad as a code owner January 10, 2024 17:44
@dependabot dependabot bot added the javascript Pull requests that update Javascript code label Jan 10, 2024
@dependabot dependabot bot requested a review from samajammin as a code owner January 10, 2024 17:44
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit a776160
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65f9cb854d88cb000815d47d
😎 Deploy Preview https://deploy-preview-981--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Jan 10, 2024

Bumps @openzeppelin/contracts from 4.9.5 to 5.0.1.

Release notes
Changelog
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

@0xmad reckon there's a way to prevent upgrading to packages with breaking changes? like if CI fails after update to just close itself? or what you think we should do in cases like this?

@0xmad
Copy link
Collaborator

0xmad commented Jan 10, 2024

@ctrlc03 I just update it manually but in case if there is a version we don't want to support we can just ignore this version with comment and it will be automatically closed and won't bother us again.

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Jan 10, 2024

@ctrlc03 I just update it manually but in case if there is a version we don't want to support we can just ignore this version with comment and it will be automatically closed and won't bother us again.

Nice, thanks for explaining!

@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from 5ef66ff to df3e4c4 Compare January 10, 2024 19:05
@0xmad
Copy link
Collaborator

0xmad commented Jan 10, 2024

@ctrlc03 @kittybest @samajammin @yuetloo this PR contains @openzeppelin/contracts update which requires solidity compiler version 0.8.20.

@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch 2 times, most recently from ac37847 to 2a2be60 Compare January 10, 2024 19:17
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Jan 10, 2024

@ctrlc03 @kittybest @samajammin @yuetloo this PR contains @openzeppelin/contracts update which requires solidity compiler version 0.8.20.

@0xmad wondering if it's a good idea to update to 0.8.20 considering some chains still don't support the opcode 'push0' that was introduced with this version? example: https://docs.arbitrum.io/for-devs/concepts/differences-between-arbitrum-ethereum/solidity-support

@0xmad
Copy link
Collaborator

0xmad commented Jan 10, 2024

@ctrlc03 ok, we can leave this PR for now and wait when 0.8.20 is supported.

@yuetloo
Copy link
Contributor

yuetloo commented Jan 10, 2024

@ctrlc03 @kittybest @samajammin @yuetloo this PR contains @openzeppelin/contracts update which requires solidity compiler version 0.8.20.

@0xmad wondering if it's a good idea to update to 0.8.20 considering some chains still don't support the opcode 'push0' that was introduced with this version? example: https://docs.arbitrum.io/for-devs/concepts/differences-between-arbitrum-ethereum/solidity-support

Does it mean that after this PR, we need to explicitly set evmVersion to target paris when we compile the contracts for Abitrum?

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Jan 10, 2024

@ctrlc03 @kittybest @samajammin @yuetloo this PR contains @openzeppelin/contracts update which requires solidity compiler version 0.8.20.

@0xmad wondering if it's a good idea to update to 0.8.20 considering some chains still don't support the opcode 'push0' that was introduced with this version? example: https://docs.arbitrum.io/for-devs/concepts/differences-between-arbitrum-ethereum/solidity-support

Does it mean that after this PR, we need to explicitly set evmVersion to target paris when we compile the contracts for Abitrum?

yup, I would skip this upgrade for now tbh, seems like @0xmad too agrees

@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch 2 times, most recently from 2af792e to bde98b2 Compare January 11, 2024 22:51
@dependabot dependabot bot requested a review from crisgarner as a code owner January 11, 2024 22:51
@ctrlc03 ctrlc03 requested a review from kittybest January 15, 2024 16:33
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from bde98b2 to acde537 Compare January 16, 2024 17:15
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from acde537 to 7f42f28 Compare January 23, 2024 22:36
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from 7f42f28 to 3bfeddc Compare February 20, 2024 17:05
@0xmad 0xmad requested a review from ctrlc03 February 20, 2024 17:05
@0xmad
Copy link
Collaborator

0xmad commented Feb 20, 2024

@ctrlc03 seems push0 is now supported

@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from c8ed2d5 to 6905c32 Compare April 2, 2024 13:46
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from 6905c32 to 67ce4e7 Compare April 4, 2024 14:35
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from 67ce4e7 to d6fa869 Compare April 8, 2024 14:25
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from d6fa869 to 0059a99 Compare April 10, 2024 15:34
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from 0059a99 to 87dbe2f Compare April 11, 2024 18:53
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from 87dbe2f to 5e1f6b1 Compare April 12, 2024 13:38
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from 5e1f6b1 to 966ee1f Compare April 12, 2024 18:43
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch 2 times, most recently from 6a941b1 to c770a6b Compare April 16, 2024 15:34
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from c770a6b to b542ef1 Compare April 16, 2024 17:50
@0xmad 0xmad force-pushed the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch from b542ef1 to 9653154 Compare April 17, 2024 17:11
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Apr 17, 2024

@ctrlc03 seems push0 is now supported

should we merge it then?

@0xmad
Copy link
Collaborator

0xmad commented Apr 17, 2024

@ctrlc03 seems push0 is now supported

should we merge it then?

I don't mind but these changes will force users to update their own contract to the new solidity version.

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Apr 17, 2024

@ctrlc03 seems push0 is now supported

should we merge it then?

I don't mind but these changes will force users to update their own contract to the new solidity version.

guess as no one is using this latest dev changes, it might be fine? afaik clr.fund uses the 1.2 release

@0xmad 0xmad merged commit 3b1914c into dev Apr 18, 2024
19 checks passed
@0xmad 0xmad deleted the dependabot/npm_and_yarn/dev/openzeppelin/contracts-5.0.1 branch April 18, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants