-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump @openzeppelin/contracts from 4.9.5 to 5.0.2 #981
chore(deps): bump @openzeppelin/contracts from 4.9.5 to 5.0.2 #981
Conversation
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@0xmad reckon there's a way to prevent upgrading to packages with breaking changes? like if CI fails after update to just close itself? or what you think we should do in cases like this? |
@ctrlc03 I just update it manually but in case if there is a version we don't want to support we can just ignore this version with comment and it will be automatically closed and won't bother us again. |
Nice, thanks for explaining! |
5ef66ff
to
df3e4c4
Compare
@ctrlc03 @kittybest @samajammin @yuetloo this PR contains |
ac37847
to
2a2be60
Compare
@0xmad wondering if it's a good idea to update to 0.8.20 considering some chains still don't support the opcode 'push0' that was introduced with this version? example: https://docs.arbitrum.io/for-devs/concepts/differences-between-arbitrum-ethereum/solidity-support |
@ctrlc03 ok, we can leave this PR for now and wait when 0.8.20 is supported. |
Does it mean that after this PR, we need to explicitly set |
yup, I would skip this upgrade for now tbh, seems like @0xmad too agrees |
2af792e
to
bde98b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solidity 0.8.20 is not fully supported https://docs.arbitrum.io/for-devs/concepts/differences-between-arbitrum-ethereum/solidity-support
bde98b2
to
acde537
Compare
acde537
to
7f42f28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
7f42f28
to
3bfeddc
Compare
@ctrlc03 seems push0 is now supported |
c8ed2d5
to
6905c32
Compare
6905c32
to
67ce4e7
Compare
67ce4e7
to
d6fa869
Compare
d6fa869
to
0059a99
Compare
0059a99
to
87dbe2f
Compare
87dbe2f
to
5e1f6b1
Compare
5e1f6b1
to
966ee1f
Compare
6a941b1
to
c770a6b
Compare
c770a6b
to
b542ef1
Compare
b542ef1
to
9653154
Compare
should we merge it then? |
I don't mind but these changes will force users to update their own contract to the new solidity version. |
guess as no one is using this latest dev changes, it might be fine? afaik clr.fund uses the 1.2 release |
Bumps @openzeppelin/contracts from 4.9.5 to 5.0.1.
Release notes
Sourced from
@openzeppelin/contracts
's releases.... (truncated)
Changelog
Sourced from
@openzeppelin/contracts
's changelog.... (truncated)
Commits
01ef448
Release v5.0.1 (#4785)9ce0340
Make Multicall context-aware4eb67a4
Closeaccess-control.adoc
code block (#4726) (#4727)83330a6
AddAccessManager
guide (#4691) (#4724)ab967b8
Update the "utilities" documentation page (#4678)a34d986
Add note aboutSafeMath.sol
remaining functions moved toMath.sol
(#4676)5161a4d
Document ERC1155 event differences (#4666)932fddf
Release v5.0.0 (#4662)7399588
Remove v5.0 release candidate note and add audit (#4663)1273541
Exit release candidateYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)