Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relayer): add auth guard for message publishing #2071

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jan 27, 2025

Description

  • Add authorization guard
  • Add more e2e tests with real scenarios
  • Update cli join poll
  • Update public circuit inputs for poll contract
  • Update poll joined offchain circuit inputs
  • Use actual state tree depth for poll joined circuit

Additional Notes

This is a part of happy offchain path

Related issue(s)

Related to privacy-scaling-explorations/maci-platform#279

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@0xmad 0xmad added the enhancement New feature or request label Jan 27, 2025
@0xmad 0xmad self-assigned this Jan 27, 2025
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jan 28, 2025 5:39pm

packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
@0xmad 0xmad force-pushed the feature/auth-guard branch from 88e6744 to 1d2eee3 Compare January 27, 2025 22:24
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments. Also, the command to send votes + proof will come in a separate PR right?

package.json Outdated Show resolved Hide resolved
apps/relayer/ts/message/message.dto.ts Outdated Show resolved Hide resolved
@0xmad
Copy link
Collaborator Author

0xmad commented Jan 28, 2025

@ctrlc03 send votes is already added. The only features to add are fetchers for messages and ipfs hashes of batches.

@0xmad 0xmad force-pushed the feature/auth-guard branch 2 times, most recently from 41bc687 to 7efea1e Compare January 28, 2025 15:28
@0xmad 0xmad requested a review from ctrlc03 January 28, 2025 15:28
@0xmad 0xmad force-pushed the feature/auth-guard branch from 7efea1e to 58cbba1 Compare January 28, 2025 16:30
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

- [x] Add authorization guard
- [x] Add more e2e tests with real scenarios
- [x] Update cli join poll
- [x] Update public circuit inputs for poll contract
- [x] Update poll joined offchain circuit inputs
- [x] Use actual state tree depth for poll joined circuit
- [x] Save poll state tree roots for public inputs onchain
@0xmad 0xmad force-pushed the feature/auth-guard branch from 58cbba1 to 813bfc7 Compare January 28, 2025 17:24
@0xmad 0xmad merged commit 4adcd53 into dev Jan 28, 2025
23 checks passed
@0xmad 0xmad deleted the feature/auth-guard branch January 28, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants