-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(circuits): unify circuits compilation and zkey generation processes #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
January 15, 2024 09:36
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
feat/unify-snark-processes
branch
3 times, most recently
from
January 15, 2024 10:18
2fdf055
to
b62ab6e
Compare
ctrlc03
changed the title
faet(circuits): unify circuits compilation and zkey generation processes
feat(circuits): unify circuits compilation and zkey generation processes
Jan 15, 2024
ctrlc03
force-pushed
the
feat/unify-snark-processes
branch
8 times, most recently
from
January 15, 2024 15:08
23db1cb
to
98eb3f0
Compare
kittybest
reviewed
Jan 15, 2024
ctrlc03
force-pushed
the
feat/unify-snark-processes
branch
2 times, most recently
from
January 15, 2024 15:30
96a5239
to
30b34c2
Compare
ctrlc03
added
dependencies
Pull requests that update a dependency file
devops
A DevOps related task
testing
Issue/PR related to tests
documentation
Improvements or additions to documentation
circuits
Related to the Circom circuits
labels
Jan 15, 2024
kittybest
reviewed
Jan 15, 2024
ctrlc03
force-pushed
the
feat/unify-snark-processes
branch
from
January 15, 2024 15:45
30b34c2
to
d1b2345
Compare
0xmad
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks, just some comments.
kittybest
reviewed
Jan 15, 2024
ctrlc03
force-pushed
the
feat/unify-snark-processes
branch
2 times, most recently
from
January 15, 2024 15:52
5085910
to
77411c0
Compare
kittybest
reviewed
Jan 15, 2024
ctrlc03
force-pushed
the
feat/unify-snark-processes
branch
from
January 15, 2024 15:57
77411c0
to
95c377d
Compare
kittybest
approved these changes
Jan 15, 2024
remove zkey-manager and custom scripts in favour of circomkit, to build circuits and generate testing zkeys. Update docs to reflect the change.
ctrlc03
force-pushed
the
feat/unify-snark-processes
branch
from
January 15, 2024 16:13
95c377d
to
d79e9c0
Compare
0xmad
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
circuits
Related to the Circom circuits
dependencies
Pull requests that update a dependency file
devops
A DevOps related task
documentation
Improvements or additions to documentation
testing
Issue/PR related to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR amends how we build circuits with custom parameters and how we generate the zkeys. Previously we used zkey-manager from the cli folder, now given we use circomkit for testing, we can also use it to build custom circuits and generate the zkeys. The goal is to simplify the process to users.
Should a user/developer wish to build the circuits and generate the zkeys for testing, all they would have to do now is to run the following from the root of the monorepo:
To generate custom circuits, this can be done by changing the
circuits/circom/circuits.json
file.The documentation and ci workflows have been updated to reflect the changes.
Additional Notes
ps. I had to add
big-integer
as a dev dependency as it looks like it's needed byoptimisedmt
(and was shared by some dependency ofzkey-manager
before)Confirmation