Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure icon to Octicons #990

Closed
wants to merge 2 commits into from
Closed

add azure icon to Octicons #990

wants to merge 2 commits into from

Conversation

pansyng
Copy link

@pansyng pansyng commented Oct 13, 2023

@arisacoba has created Azure Icon for vnet public beta use. Proposing to add to Octicons for future usage.
Following contributing guideline:

  • added azure icon in icons folder
  • update keyword.json

@pansyng pansyng requested a review from a team as a code owner October 13, 2023 07:35
@pansyng pansyng requested a review from gavinmn October 13, 2023 07:35
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

⚠️ No Changeset found

Latest commit: 7b9d57e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arisacoba
Copy link
Member

Wanna clarify that I didn't create this but it's from Azure 😅

@gavinmn
Copy link
Contributor

gavinmn commented Oct 13, 2023

@tallys what's the latest on including branding elements like this in Octicons?

@tallys
Copy link
Contributor

tallys commented Oct 16, 2023

hi @pansyng we do not include nor open source logomarks or brand elements in Octicons - the infrastructure for that is Octovisuals and we are still setting that up. Our recommendation is to use the icon in place as is, and we can include this icon in our plans for Octovisuals as we get that up and running.

@tallys tallys closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants