You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my local tests, running yarn build in lib/octicons_node generates build/build/svg but after this change it generates build/svg, so it should fix the issue.
However the build is a bit of spaghetti between workflows, docker entrypoints.js and multiple package.json, so it's not entirely clear if further work is required (probably not)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.
I'm not sure what's going on with these build failures, but I assume it's because this PR was created from a fork. I just pushed a copy up to origin to see if that fixes things: #1010
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my local tests, running
yarn buildinlib/octicons_nodegeneratesbuild/build/svgbut after this change it generatesbuild/svg, so it should fix the issue.However the build is a bit of spaghetti between workflows, docker entrypoints.js and multiple package.json, so it's not entirely clear if further work is required (probably not)