Skip to content

Commit

Permalink
Fix linting issues; cache bundles
Browse files Browse the repository at this point in the history
  • Loading branch information
camertron committed Jan 22, 2024
1 parent f11c530 commit 13ce832
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2
bundler-cache: true
- uses: actions/download-artifact@v4
with:
name: octicons-build
Expand Down Expand Up @@ -131,6 +132,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2
bundler-cache: true
- uses: actions/download-artifact@v4
with:
name: octicons-gem
Expand All @@ -154,6 +156,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2
bundler-cache: true
- uses: actions/download-artifact@v4
with:
name: octicons-gem
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2
bundler-cache: true

- name: Install dependencies
run: |
Expand Down
2 changes: 2 additions & 0 deletions lib/octicons_helper/test/octicons_helper_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@

it "caches SVGs for two calls with the same arguments" do
OcticonsHelper.octicons_helper_cache = {}
# rubocop:disable Lint/BinaryOperatorWithIdenticalOperands
assert octicon("alert").object_id == octicon("alert").object_id
# rubocop:enable Lint/BinaryOperatorWithIdenticalOperands
OcticonsHelper.octicons_helper_cache = {}
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/octicons_jekyll/Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ RuboCop::RakeTask.new(:lint) do |t|
t.options = ["--display-cop-names"]
end

task :version, [:v] do |t, args|
task :version, [:v] => :environment do |t, args|
out = "# Prevent bundler errors\n"\
"module Liquid; class Tag; end; end\n\n"\
"module Jekyll\n"\
Expand Down

0 comments on commit 13ce832

Please sign in to comment.