Docs: add a11y guidance regarding required fields #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
approved these changes
Oct 18, 2024
Co-authored-by: Armağan <[email protected]>
|
Just waiting until primer/react#5027 makes it into a release as to not have the docs be ahead of the code. |
francinelucca
deleted the
francinelucca/docs/form-control-a11y-guidance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primer/react#5027 Introduces the ability to allow required check boxes both individually and within a Checkbox group as per:
This PR updates the docs guidance to reflect these changes:
Changed
requiredfield in Checkbox and Radio as per suggested in fix(FormControl): allow required check boxes react#5027 (review)Screenshots
Checkbox:
Form Control:
Forms:
