fix: resolve type conflict by updating primevue
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, cc @mertsincan |
| @@ -44,7 +44,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@nuxt/kit": "^3.7.3", | |||
| "primevue": "~3.49.1" | |||
| "primevue": "~3.51.0" | |||
There was a problem hiding this comment.
Current approach of allowing patch-only updates might be too restrictive and relies on maintainers to act, potentially locking end users from getting the latest updates as soon as they get released (including myself).
Suggested change
| "primevue": "~3.51.0" | |
| "primevue": "^3.51.0" |
There was a problem hiding this comment.
I agree this would be the better approach but wasn't sure if there is a specific reasoning behind version pinning so I kept that as is, I'll leave it up to the maintainers whether this should be more permissive.
/cc @mertsincan
|
It would be great to get this merged, otherwise types are broken for a Nuxt project without manual resolutions workaround. |
|
Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
primevueto the latest version which includes primefaces/primevue#5419 to prevent nuxt/nuxt#26214 from happening.