Reduce noise from fuzzing, or various unexpected inputs #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e message lookup to fail when no action invocation exists.
wied03
approved these changes
Jan 22, 2025
| @@ -79,7 +79,8 @@ public String getMessage(String key, Object... values) throws MissingMessageExce | |||
| String message = getOptionalMessage(key, values); | |||
| if (message == null) { | |||
| ActionInvocation actionInvocation = invocationStore.getCurrent(); | |||
| throw new MissingMessageException("Message could not be found for the URI [" + actionInvocation.actionURI + "] and key [" + key + "]"); | |||
| String uri = actionInvocation != null ? actionInvocation.actionURI : null; | |||
There was a problem hiding this comment.
From looking at this and playing w/ it locally, it looks like the source of noise was from NPEs, which this 'solves', right?
There was a problem hiding this comment.
Correct. It does solve the NPE.
I suppose we could also consider not logging this message at all if there is no action invocation. But my primary goal was to remove the NPE I saw in some customer logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce noise from fuzzing, or various unexpected inputs that may cause message lookup to fail when no action invocation exists.
Fixes #67