Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actionURI may be null and causes noise in the logs during findMessage #67

Closed
robotdan opened this issue Nov 26, 2024 · 0 comments · Fixed by #68
Closed

actionURI may be null and causes noise in the logs during findMessage #67

robotdan opened this issue Nov 26, 2024 · 0 comments · Fixed by #68

Comments

@robotdan
Copy link
Member

If we perform any message lookups in the DefaultExceptionHandler we make take a NPE expecting the invocationStore.getCurrent() to return a non null value for the ActionInvocation.

We could be more defensive if there are edge cases where we will not have an action invocation.

2024-11-26 04:06:24.566 AM ERROR org.primeframework.mvc.PrimeMVCRequestHandler - Error encountered
java.lang.NullPointerException: Cannot read field "actionURI" because "actionInvocation" is null
        at org.primeframework.mvc.message.l10n.ResourceBundleMessageProvider.findMessage(ResourceBundleMessageProvider.java:129)
        at org.primeframework.mvc.message.l10n.ResourceBundleMessageProvider.getOptionalMessage(ResourceBundleMessageProvider.java:88)
        at org.primeframework.mvc.message.l10n.ResourceBundleMessageProvider.getMessage(ResourceBundleMessageProvider.java:76)
        at io.fusionauth.app.primeframework.error.ExceptionExceptionHandler.handle(ExceptionExceptionHandler.java:48)
        at io.fusionauth.app.primeframework.error.ExceptionExceptionHandler.handle(ExceptionExceptionHandler.java:22)
        at org.primeframework.mvc.workflow.DefaultExceptionHandler.handle(DefaultExceptionHandler.java:64)
        at org.primeframework.mvc.workflow.DefaultMVCWorkflow.perform(DefaultMVCWorkflow.java:116)
        at org.primeframework.mvc.PrimeMVCRequestHandler.handle(PrimeMVCRequestHandler.java:73)
        at io.fusionauth.http.server.HTTPWorker.run(HTTPWorker.java:50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant