New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : build 에러 수정 #468

Merged

HelloWook merged 1 commit into main from refactor-조회-페이지-수정-

Jan 4, 2025

Member

HelloWook commented Jan 4, 2025 •

edited

Loading

🚀요약

일기 조회 페이지 리펙토링
build 에러 수정

📸사진 (구현 캡처)

📝작업 내용

일기 조회 페이지 리펙토링
컴파운드 패턴 적용
위에 맞게 라우터 수정

🔍전달 사항

차후 조회 컨테이너를 hoc로 리펙토링 하겠습니다.


          fix : build 에러 수정

38f9d49

HelloWook added the ♻️ refactor label

HelloWook self-assigned this

HelloWook requested review from kangminguu, cmlim0070, mmjjaa and saseungmin as code owners

January 4, 2025 19:55

github-actions bot commented Jan 4, 2025

✅ Build 성공!

github-actions bot commented Jan 4, 2025

🚀 storybook: https://67374052168fb974acee4466-ofvuzwbspm.chromatic.com/

github-actions bot commented Jan 4, 2025

⚡️ Lighthouse Report (Average of 5 runs)

Category	Score
🟠 Performance	78
🟠 Accessibility	65
🟢 SEO	90
🟢 Best Practices	100

Core Web Vitals (Average)

Metric	Value
🔴 First Contentful Paint	3.9 s
🔴 Largest Contentful Paint	4.1 s
🟢 Cumulative Layout Shift	0.0

HelloWook merged commit 68e23fc into main

3 checks passed

HelloWook changed the title ~~refactor: 일기 조회 페이지 리펙토링~~ fix : build 에러 수정

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kangminguu Awaiting requested review from kangminguu kangminguu is a code owner

cmlim0070 Awaiting requested review from cmlim0070 cmlim0070 is a code owner

mmjjaa Awaiting requested review from mmjjaa mmjjaa is a code owner

saseungmin Awaiting requested review from saseungmin saseungmin is a code owner

Labels

♻️ refactor