Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] 불필요한 파일 제거, 컨벤션에 따라 코드 정렬, 수정 #157

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

chogyejin
Copy link
Member

📌 기능 설명

전반적인 코드베이스 리팩토링

👩‍💻 요구 사항과 구현 내용

dummy 데이터 제거, 컨벤션에 따라 코드 정렬했습니다.

구현 결과

@chogyejin chogyejin self-assigned this Jul 12, 2022
@vercel
Copy link

vercel bot commented Jul 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
shallenge ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 8:22AM (UTC)

Copy link
Member

@nyoung113 nyoung113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

누군가 해야 할 일을 해주셨네요...!!👍 감사합니다... 코드 전반적인 수정인만큼 이것 부터 얼른 합치는게 좋을 것 같습니답..!!

introduce: string;
followerCount: number;
followingCount: number;
id: string;
}

const MySummary = ({ introduce, followerCount, followingCount, id }: Props) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 여기 부분 컨벤션에 맞게 고쳤는데 그것 때문에 충돌이 일어날 수 있겠네요🥲 일단 계진님 것 합치고 제꺼 합쳐보면 될 것 같아요!

Copy link
Member

@wogha95 wogha95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 파일 찾으시면서 하셨을거 같은데 정말 수고많으셨습니다!

@chogyejin chogyejin merged commit b986374 into main Jul 14, 2022
@sa02045 sa02045 deleted the refactor/styles branch July 24, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants