Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] import 정렬 #139

Closed
wants to merge 6 commits into from
Closed

[Feature] import 정렬 #139

wants to merge 6 commits into from

Conversation

sa02045
Copy link
Member

@sa02045 sa02045 commented Jul 2, 2022 •
edited
Loading

📌 기능 설명

1.

  • eslint를 사용해 import문을 정렬합니다
  • 정렬규칙은 eslintrc.json의 rule "import/order"에 정의되어있습니다

2.

  • @로 시작하는 alias를 변경합니다. 왜냐하면 외부라이브러리와 내부코드의 구분이 어렵기때문입니다.
@chara-ui // 외부 라이브러리
@components // 내부 코드

변경 후

@/components

3. ChakraHeading 컴포넌트 수정

  • @chakra-ui/react에 존재하지 않는 TypographyProps 오류 수정

에러가 뜨길래 해당 프러퍼티를 삭제했습니다.

👩‍💻 요구 사항과 구현 내용

구현 결과

@sa02045 sa02045 self-assigned this Jul 2, 2022
@sa02045 sa02045 requested a review from wogha95 as a code owner July 2, 2022 13:50
@vercel
Copy link

vercel bot commented Jul 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
shallenge ❌ Failed (Inspect) Jul 7, 2022 at 3:20PM (UTC)

@sa02045 sa02045 linked an issue Jul 3, 2022 that may be closed by this pull request
[1주차]import문 통일 정렬하기 #128
Closed
@sa02045 sa02045 closed this Jul 17, 2022
@sa02045 sa02045 deleted the feature/import-정렬 branch July 24, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wogha95 wogha95 wogha95 approved these changes

@chogyejin chogyejin Awaiting requested review from chogyejin chogyejin is a code owner

@nyoung113 nyoung113 Awaiting requested review from nyoung113 nyoung113 is a code owner

Assignees

@sa02045 sa02045

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1주차]import문 통일 정렬하기
2 participants
@sa02045 @wogha95