[Fix] 마이페이지에서 챌린지 이동 시 url undefined 오류 수정 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sa02045
reviewed
Jun 29, 2022
| const jsonString = challenge.title.replaceAll("'", '"'); | ||
| const jsonObject = JSON.parse(jsonString); | ||
| return ( | ||
| <CardContainer | ||
| key={challenge._id} | ||
| onClick={() => { | ||
| handleChallengeClick(challenge.channel._id, challenge._id); | ||
| handleChallengeClick( | ||
| challenge.channel as unknown as string, |
There was a problem hiding this comment.
as unknown as string 는 어떤 의미인가요...? 결국 string 타입이라는 뜻일까요..
There was a problem hiding this comment.
말씀해주신 뜻이 맞습니다! challege가 Post interface를 따라서 channel이라는 속성이 Channel interface를 갖고 있는데, 바로 as string으로는 형변환이 안되고 unknown으로 한 번 바꿔주고 string으로 바꿔줘야 하더라구요.. 썩 좋은 방법은 아닌 거 같지만 당장 문제는 해결돼서 일단 이렇게 수정했었습니다
sa02045
reviewed
Jun 29, 2022
| @@ -18,6 +17,7 @@ const UserInfo = styled.div` | |||
| const MyProfilePage = () => { | |||
| const [myUser] = useAtom(userAtom); | |||
| usePageTitle(myUser.fullName); | |||
|
|
|||
There was a problem hiding this comment.
jsx return 하는 곳이랑 딱 붙어 있어서 한 줄 띄웠던 거로 기억합니다!
sa02045
approved these changes
Jun 30, 2022
nyoung113
approved these changes
Jun 30, 2022
wogha95
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 기능 설명
챌린지 url 오류 수정
👩💻 요구 사항과 구현 내용
MyProfilePage에서 MyChallenges 컴포넌트를 이용하여 내 챌린지들을 보여주는데, 이때 클릭 시 channel id가 제대로 반영되지 않던 오류를 수정했습니다. 이제부터 정상적으로 접근하여 잔디 심기가 가능합니다.
구현 결과