Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5기 임수진] SprintBoot URL Shortener 구현 미션 제출합니다. #66

Open
wants to merge 17 commits into
base: suzzingV
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[REFACT] import 정리
suzzingV committed Dec 16, 2023
commit 04b77e5cbd60b6d27b80963013dba20c7f7a31be
1 change: 0 additions & 1 deletion src/main/java/com/prgrms/shorturl/domain/Url.java
Original file line number Diff line number Diff line change
@@ -3,7 +3,6 @@
import com.prgrms.shorturl.utils.Base62EncodingFactory;
import com.prgrms.shorturl.utils.EncodingFactory;
import com.prgrms.shorturl.utils.HashAlgorithm;
import com.prgrms.shorturl.utils.HashFactory;
import jakarta.persistence.*;
import lombok.Getter;
import lombok.NoArgsConstructor;
4 changes: 2 additions & 2 deletions src/main/java/com/prgrms/shorturl/service/UrlService.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.prgrms.shorturl.service;

import com.prgrms.shorturl.utils.*;
import com.prgrms.shorturl.domain.Url;
import com.prgrms.shorturl.dto.UrlRequest;
import com.prgrms.shorturl.dto.UrlResponse;
import com.prgrms.shorturl.exception.NoSuchOriginalUrlException;
import com.prgrms.shorturl.repository.UrlRepository;
import com.prgrms.shorturl.utils.HashAlgorithm;
import jakarta.validation.Valid;
import jakarta.validation.constraints.NotEmpty;
import lombok.RequiredArgsConstructor;
@@ -16,7 +16,7 @@

import java.util.Optional;

import static com.prgrms.shorturl.dto.UrlResponse.*;
import static com.prgrms.shorturl.dto.UrlResponse.toShortUrlResponse;
import static com.prgrms.shorturl.utils.UrlFactory.deleteProtocol;
import static com.prgrms.shorturl.utils.UrlFactory.extractProtocol;

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.prgrms.shorturl.utils;

import com.prgrms.shorturl.domain.Url;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

2 changes: 0 additions & 2 deletions src/main/java/com/prgrms/shorturl/utils/EncodingFactory.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.prgrms.shorturl.utils;

import com.prgrms.shorturl.domain.Url;

public interface EncodingFactory {
String encode();
}
6 changes: 2 additions & 4 deletions src/test/java/com/prgrms/shorturl/service/UrlServiceTest.java
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
package com.prgrms.shorturl.service;

import com.prgrms.shorturl.domain.Url;
import com.prgrms.shorturl.dto.UrlRequest;
import com.prgrms.shorturl.dto.UrlResponse;
import com.prgrms.shorturl.exception.NoSuchOriginalUrlException;
import com.prgrms.shorturl.repository.UrlRepository;
import com.prgrms.shorturl.utils.HashAlgorithm;
import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.context.annotation.Profile;

import static org.assertj.core.api.Assertions.*;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

@SpringBootTest
class UrlServiceTest {