Skip to content

Commit

Permalink
Fix: 랜덤 정수가 음수가 되지 않도록 수정한다.
Browse files Browse the repository at this point in the history
  • Loading branch information
ZZAMBAs committed Dec 15, 2023
1 parent 41e8704 commit c26e7e5
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ public ShortUrlService(@Qualifier("BASE62") UrlTransformer urlTransformer, Short

public String saveOriginalUrl(String originalUrl) {
Random random = new Random();
int randomInt = random.nextInt();
int randomInt = random.nextInt(0, Integer.MAX_VALUE);
String generatedUrl = urlTransformer.generateUrl(randomInt);

while (urlRepository.findById(generatedUrl).isPresent()) {
randomInt = random.nextInt();
randomInt = random.nextInt(0, Integer.MAX_VALUE);
generatedUrl = urlTransformer.generateUrl(randomInt);
}

Expand All @@ -44,11 +44,11 @@ public String getOriginalUrl(String encodedUrl) {

increaseVisit(shortUrl);

return shortUrl.getTransformedUrl();
return shortUrl.getOriginalUrl();
}

private void increaseVisit(ShortUrl shortUrl) {
shortUrl.increaseVisit();
urlRepository.updateVisitCount(shortUrl.getTransformedUrl());
urlRepository.save(shortUrl);
}
}

0 comments on commit c26e7e5

Please sign in to comment.