[BUG] not working with eslint 6 #870

jimblue · 2019-07-09T12:27:14Z

Hi,

When using the option eslint-integration, Prettier is not working and output the following error:

ENOENT/home/dev/frontend/webpacker/app/index.js:: no such file or directory, open '/home/dev/projects/frontend/node_modules/eslint/lib/linter.js'

I've check in my node_modules and effectively, linter.js doesn't exist.

It was previously working with eslint version 5 because linter.js did exist at this path here.

But in eslint version 6, linter.js has been moved in a subfolder here.

That's why it's actually broken.
So basically all you have to do is to modify the require:

from:

require /node_modules/eslint/lib/linter.js

to:

require /node_modules/eslint/lib/linter/index.js

Cheers

The text was updated successfully, but these errors were encountered:

jakeleventhal · 2019-07-11T15:34:36Z

Need this ASAP!

chengjia080787 · 2019-07-22T14:23:50Z

any luck on this? it's a critical issue to be honest

mbalaam · 2019-07-22T14:47:35Z

I’ve ended up removing the extension and I am using https://github.com/prettier/eslint-plugin-prettier instead.

tcodes0 · 2019-07-30T01:26:11Z

running "prettier.eslintIntegration": false as a work around

asbjornh · 2019-08-07T13:00:38Z

to:

require /node_modules/eslint/lib/linter/index.js

Maybe change to require('node_modules/eslint/lib/linter') instead? Node's module resolution would then check both linter.js and linter/index.js. If the import looked like that in the first place we wouldn't have an issue now 😃

asbjornh · 2019-08-08T15:01:37Z

@jimblue Where is that require call coming from? I can't see that this package imports eslint anywhere in the source and eslint isn't listed in package.json either. I tried grep'ing the plugin folder and nothing really looks suspicious.

In ~/.vscode/extensions/esbenp.prettier-vscode-1.9.0:

$ grep -r "/linter" .
./node_modules/tslint/lib/test.js:var linter_1 = require("./linter");
./node_modules/tslint/lib/runner.js:var linter_1 = require("./linter");
./node_modules/tslint/lib/index.js:tslib_1.__exportStar(require("./linter"), exports);
./node_modules/tslint/lib/index.d.ts:export * from "./linter";
./node_modules/tslint/lib/tslintCli.js:var linter_1 = require("./linter");
./node_modules/prettier-tslint/dist/format.js:  // Adapted from: https://github.com/palantir/tslint/blob/5.12.0/src/linter.ts
./node_modules/eslint/lib/config/autoconfig.js:    Linter = require("../linter"),
./node_modules/eslint/lib/testers/rule-tester.js:    Linter = require("../linter"),
./node_modules/eslint/lib/api.js:const Linter = require("./linter");
./node_modules/eslint/lib/cli-engine.js:    Linter = require("./linter"),

asbjornh · 2019-08-09T14:32:56Z

I tried creating a fresh project to reproduce, and I'm now getting a different error message:

Failed to load plugin 'prettier' declared in 'CLIOptions'<project-path>/index.js:: Cannot find module 'eslint-plugin-prettier'
Require stack:
- /__placeholder__.js

eslint-plugin-prettier is most definitely installed. For anyone interested in debugging this, here is a setup for reproducing this:

  "dependencies": {
    "eslint": "^6.1.0",
    "eslint-config-prettier": "^6.0.0",
    "eslint-plugin-prettier": "^3.1.0",
    "prettier": "^1.18.2"
  }

eslintrc:

{
  "plugins": ["prettier"],
  "extends": ["prettier"],
  "rules": {
    "prettier/prettier": ["warn"]
  }
}

Running with prettier.eslintIntegration: true and selecting Format Document With from the command palette in an empty js file should result in the above error message.

asbjornh · 2019-08-11T11:41:06Z

Oh, this seems to be caused by a known issue with prettier-eslint (prettier/prettier-eslint#222). I guess we'll have to wait for them to fix that first :)

ntotten · 2019-08-12T14:58:34Z

As mentioned above, there is an upstream dependancy on the prettier eslint module. It is not yet compatible with eslint 6. see: prettier/prettier-eslint#222

ntotten · 2019-08-12T19:13:28Z

After investigating these issues we are considering removing support for linters in version 2.0.0. Instead of incorporating the linters into this extension the proposal is to use the ESLint or TSLint extensions along with this extension. Please let us know what you think by commenting on #901.

By using the official extensions issues like these will be centralized and fixed more quickly as the authors of those extensions are focusing solely on those linters.

ntotten · 2019-08-25T14:00:00Z

Here is a good article explaining the type of setup that is recommended going forward: https://dorshinar.me/linting-your-react+typescript-project-with-eslint-and-prettier

ntotten · 2019-08-25T14:06:59Z

More discussion also in #922

YuriScarbaci · 2019-08-26T09:30:08Z

Until this is fixed in the extension if anyone is relying on the eslint-vscode extension and wishes to setup a keybinding to "format" (well, fixing with eslint, but in most cases it's formatting anyway) you could set a keybindg in your vscode with "shift+alt+f" (or whatever you wish) listening to eslint.executeAutofix

for more info about this refeer to https://github.com/Microsoft/vscode-eslint/issues/70

mihaiwww · 2019-10-26T07:58:08Z

How I've sorted it after having super huge frustrations with Prettier stopping working.

VS Code -> View -> Command Palette, type: Format Document With, then Configure Default Formatter... and then choose Prettier - Code formatter.

This sorted the problem for me magically. It looks that VS Code had other options for formatting not only Prettier but did not show any error or notification so you can choose from.

I hope it helps others too!

Salles-FA · 2019-11-20T20:04:22Z

3.6.0 and 3.7.0 are ok! But it seems like the same problem is back in 3.8.0 today. Or even a similar problem.

Can you guys take a look?

Output with 3.6.0 and 3.7.0:

[INFO - 2:02:11 PM] Prettier Options:
{
  "arrowParens": "avoid",
  "bracketSpacing": true,
  "endOfLine": "auto",
  "htmlWhitespaceSensitivity": "css",
  "insertPragma": false,
  "jsxBracketSameLine": false,
  "jsxSingleQuote": true,
  "printWidth": 120,
  "proseWrap": "preserve",
  "quoteProps": "as-needed",
  "requirePragma": false,
  "semi": true,
  "singleQuote": true,
  "tabWidth": 2,
  "trailingComma": "none",
  "useTabs": false,
  "vueIndentScriptAndStyle": false,
  "filepath": "c:\\somefile.ts",
  "parser": "typescript"
}

Output with 3.8.0:

[INFO - 1:54:38 PM] Prettier Options:
    {
      "filepath": "c:\\somefime.ts",
      "parser": "typescript",
      "useTabs": false,
      "tabWidth": 2
    }

Salles-FA · 2019-12-09T14:24:14Z

Same problem with 3.11.0 here.

ntotten · 2019-12-19T18:08:25Z

ESLint 6 is NOT supported by this extension at the moment. I won’t spend time on this until the upstream libraries officially support ESLint 6. Once prettier/prettier-eslint#222 is resolved I will work on this bug.

uniquejava · 2020-01-03T04:59:49Z

Auto format on save suddenly NOT WORK in recent days, I have to format document with keyboard :(
Uninstall vscode-eslint fixed auto format on save issue!

kebot · 2020-01-06T14:42:41Z

vscode-eslint recently suggests using editor.codeActionsOnSave, and I found it doesn't work well with editor.formatOnSave because it runs eslint fix first then prettier. What I want is prettier then eslint fix.

Then I add editor.action.formatDocument to codeActionsOnSave and disable formatOnSave, everything works fine for me now.

This is my current config, tested on MacOS with:

VSCode: 1.41.1
prettier-vscode: 3.18.0
vscode-eslint: 2.0.11

{
  "[javascriptreact]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[javascript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[typescriptreact]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[typescript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "editor.formatOnSave": false,
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true,
    "editor.action.formatDocument": true
  }
}

JoelAzevedo · 2020-01-10T15:40:52Z

How I've sorted it after having super huge frustrations with Prettier stopping working.

VS Code -> View -> Command Palette, type: Format Document With, then Configure Default Formatter... and then choose Prettier - Code formatter.

This sorted the problem for me magically. It looks that VS Code had other options for formatting not only Prettier but did not show any error or notification so you can choose from.

I hope it helps others too!

I can't thank you enough. I was going almost crazy with the settings. It actually magically solved it.

Thank you x100

ntotten · 2020-02-04T19:46:30Z

It seems like prettier-eslint is mostly a dead project so it is unlikely this will ever get fixed. I would suggest switching to the recommended approach of integrating ESLint and Prettier

rohit-gohri · 2020-04-29T13:37:02Z

I couldn't get @kebot's workaround to work on the latest extension and vscode versions. So I published a small extension to run 'Format Document' as a codeAction:

https://github.com/rohit-gohri/vscode-format-code-action/

Along with the latest VS Code update, which allows setting order of codeActionsOnSave, this removes the need for prettier-eslint to specify the order of commands in VS Code. We can use the prettier-vscode and vscode-eslint extensions separately and just define the order in vscode settings.

Example here: #1277 (comment)

ntotten · 2020-06-24T17:54:25Z

Linting integration has been removed from this extension. If you want to run prettier and ESlint together you should use the ESLint extension instead. See: https://github.com/prettier/prettier-vscode#linter-integration

jimblue mentioned this issue Jul 20, 2019

Cannot find module '../ast-utils' when formating #672

Closed

This was referenced Jul 26, 2019

There is no document formatter for 'javascriptreact'-files installed. #876

Closed

prettier-eslint error #879

Closed

NWCalvank mentioned this issue Aug 7, 2019

Feature/mds 2127 bcgov/mds#916

Merged

ntotten added the bug label Aug 9, 2019

ntotten modified the milestones: 1.9.0, 1.10.0 Aug 9, 2019

ntotten mentioned this issue Aug 12, 2019

use eslint Unexpected token ... #895

Closed

ntotten added the dependency label Aug 12, 2019

ntotten removed this from the 2.0.0 milestone Aug 24, 2019

ntotten mentioned this issue Oct 20, 2019

Prettier VS Code 3.0 #958

Closed

13 tasks

ntotten mentioned this issue Nov 18, 2019

Failed to load plugin on format with 3.2.0 and 3.6.0 #1062

Closed

bfreeds mentioned this issue Jan 14, 2020

Add pre-commit linting hook NYCPlanning/ceqr-app#570

Merged

ntotten closed this as completed Feb 4, 2020

rohit-gohri mentioned this issue Apr 29, 2020

Run eslint --fix AFTER prettier on save #1277

Closed

This comment has been minimized.

Sign in to view

prettier locked as resolved and limited conversation to collaborators Jun 24, 2020

ntotten added the locked Please open a new issue and fill out the template instead of commenting. label Jul 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] not working with eslint 6 #870

[BUG] not working with eslint 6 #870

jimblue commented Jul 9, 2019

jakeleventhal commented Jul 11, 2019

chengjia080787 commented Jul 22, 2019

mbalaam commented Jul 22, 2019

tcodes0 commented Jul 30, 2019 •

edited

Loading

asbjornh commented Aug 7, 2019

asbjornh commented Aug 8, 2019 •

edited

Loading

asbjornh commented Aug 9, 2019 •

edited

Loading

asbjornh commented Aug 11, 2019

ntotten commented Aug 12, 2019

ntotten commented Aug 12, 2019 •

edited

Loading

ntotten commented Aug 25, 2019

ntotten commented Aug 25, 2019

YuriScarbaci commented Aug 26, 2019

mihaiwww commented Oct 26, 2019 •

edited

Loading

Salles-FA commented Nov 20, 2019

Salles-FA commented Dec 9, 2019

ntotten commented Dec 19, 2019 •

edited

Loading

uniquejava commented Jan 3, 2020 •

edited

Loading

kebot commented Jan 6, 2020

JoelAzevedo commented Jan 10, 2020

ntotten commented Feb 4, 2020

rohit-gohri commented Apr 29, 2020 •

edited

Loading

This comment has been minimized.

ntotten commented Jun 24, 2020

[BUG] not working with eslint 6 #870

[BUG] not working with eslint 6 #870

Comments

jimblue commented Jul 9, 2019

jakeleventhal commented Jul 11, 2019

chengjia080787 commented Jul 22, 2019

mbalaam commented Jul 22, 2019

tcodes0 commented Jul 30, 2019 • edited Loading

asbjornh commented Aug 7, 2019

asbjornh commented Aug 8, 2019 • edited Loading

asbjornh commented Aug 9, 2019 • edited Loading

asbjornh commented Aug 11, 2019

ntotten commented Aug 12, 2019

ntotten commented Aug 12, 2019 • edited Loading

ntotten commented Aug 25, 2019

ntotten commented Aug 25, 2019

YuriScarbaci commented Aug 26, 2019

mihaiwww commented Oct 26, 2019 • edited Loading

Salles-FA commented Nov 20, 2019

Salles-FA commented Dec 9, 2019

ntotten commented Dec 19, 2019 • edited Loading

uniquejava commented Jan 3, 2020 • edited Loading

kebot commented Jan 6, 2020

JoelAzevedo commented Jan 10, 2020

ntotten commented Feb 4, 2020

rohit-gohri commented Apr 29, 2020 • edited Loading

This comment has been minimized.

ntotten commented Jun 24, 2020

tcodes0 commented Jul 30, 2019 •

edited

Loading

asbjornh commented Aug 8, 2019 •

edited

Loading

asbjornh commented Aug 9, 2019 •

edited

Loading

ntotten commented Aug 12, 2019 •

edited

Loading

mihaiwww commented Oct 26, 2019 •

edited

Loading

ntotten commented Dec 19, 2019 •

edited

Loading

uniquejava commented Jan 3, 2020 •

edited

Loading

rohit-gohri commented Apr 29, 2020 •

edited

Loading