Add pugClassNotation 'attribute' option #203
Conversation
Shinigami92
added
the
type: feature request
|
You know what, a separate PR would be better. It's classes I really need and I'm not sure I'll get on to IDs soon. Hopefully this helps anyone else wanting to have a go at it! |
|
Could you update https://github.com/prettier/plugin-pug/blob/main/docs/guide/pug-specific-options.md e.g. - var clazz = 'ma-2 px-1'
div(class=clazz) |
homerjam
force-pushed
the
literals-to-attributes
branch
from
c80ff50 to
ec27266
Compare
homerjam
changed the title
|
I just broke my rebase cherry 😊 I hope you didn't want any of that whitespace in the guide, sorry about that. |
|
Ah, these whitespaces are necessary cause otherwise VuePress will render these in one line instead of adding a newline |
|
Oh no! I have an overzealous markdown formatter I'm afraid. Whitespace is restored now... |
| @@ -773,6 +775,20 @@ export class PugPrinter { | |||
| if (token.val !== true) { | |||
| this.result += `=${token.val}`; | |||
| } | |||
| } else if (token.name === 'class' && this.options.pugClassNotation === 'attribute') { | |||
| const val: string = isQuoted(token.val) ? token.val.slice(1, -1).trim() : token.val; | |||
| const classes: string[] = val.split(/\s+/); | |||
There was a problem hiding this comment.
thought: I'm a little bit afraid of this line and don't know what it's doing if the class contains js code with spaces 🤔
But I think I will merge it for now
Shinigami92
changed the title
This is a partial fix for #167 covering classes, I think it should be fairly straightforward to implement for IDs next, please let me know if this direction is right and I'll get on to it!
Thanks!