Fix python in urlgrabber-ext-down #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegecko
commented
Dec 10, 2022
| @@ -7,6 +7,7 @@ RUN groupadd -g 1000 node && useradd -g 1000 -u 1000 -m node && \ | |||
| curl -fsSL https://rpm.nodesource.com/setup_lts.x | bash - && \ | |||
| yum install -y make nodejs python3 && \ | |||
| sed -i 's/#!\/usr\/bin\/python/#!\/usr\/bin\/python2/' /usr/bin/yum && \ | |||
| sed -i 's/#! \/usr\/bin\/python/#! \/usr\/bin\/python2/' /usr/libexec/urlgrabber-ext-down && \ | |||
There was a problem hiding this comment.
Note this script has a space after the #!
|
@thegecko Tests failed on master, could you have a look? https://github.com/prebuild/docker-images/actions/runs/3665704437/jobs/6196951730 |
|
Hmm, took a quick look. It seems to fail before my change when installing Node. This could be a new failure due to dependency changes in node 18 (and it being the new LTS). Did node 18 build in this container before? |
Ah right. Node 18 is incompatible with CentOS 7, so until we upgrade (prebuild/prebuildify-cross#13) I will pin node to 16. |
vweevers
added a commit
that referenced
this pull request
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace python version in
/usr/libexec/urlgrabber-ext-downto fix yum oncentos7-devtoolset7Fixes #28