Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable onChange and route() during SSR #331

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+24 −11
Open

Disable onChange and route() during SSR #331

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a369bf
Disable onChange and route() during SSR
developit Aug 10, 2019
359d11d
Merge branch 'master' into ssr-fixes
developit Oct 18, 2019
0631c28
Merge branch 'master' into ssr-fixes
developit Oct 21, 2019
647ec98
Adopt Preact X -compatible version
developit Oct 21, 2019
ce3002e
update comment
developit Oct 21, 2019
373ecee
Fix inverted SSR condition.
developit Oct 21, 2019
3f498b4
Update tests to simulate client-side rendering
developit Oct 21, 2019
dcb3afa
Update index.js
developit Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ class Router extends Component {
this.state = {
url: props.url || getCurrentUrl()
};

initEventListeners();
}

Expand Down Expand Up @@ -179,7 +179,12 @@ class Router extends Component {
}

componentWillMount() {
ROUTERS.push(this);
// preact-render-to-string does not initialize the "next state" field for components.
// We can use this to detect a static rendering environment and disable subscriptions.
this._ssr = '_nextState' in this || '__s' in this;
developit marked this conversation as resolved.
Show resolved Hide resolved
if (!this._ssr) {
ROUTERS.push(this);
}
this.updating = true;
}

Expand All @@ -194,7 +199,7 @@ class Router extends Component {

componentWillUnmount() {
if (typeof this.unlisten==='function') this.unlisten();
ROUTERS.splice(ROUTERS.indexOf(this), 1);
ROUTERS.splice(ROUTERS.indexOf(this) >>> 0, 1);
}

componentWillUpdate() {
Expand Down Expand Up @@ -230,7 +235,7 @@ class Router extends Component {
let current = active[0] || null;

let previous = this.previousUrl;
if (url!==previous) {
if (!this._ssr && url!==previous) {
this.previousUrl = url;
if (typeof onChange==='function') {
onChange({
Expand Down