Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ForkTsCheckerWebpackPlugin which presented random lockin… #1818

Merged
merged 3 commits into from
Jan 27, 2024
Merged

feat: update ForkTsCheckerWebpackPlugin which presented random lockin… #1818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90c52e5
feat: update ForkTsCheckerWebpackPlugin which presented random lockin…
Jan 27, 2024
cb72648
chore: update yarn lock after updating fork-ts-checker-webpack-plugin
Jan 27, 2024
4c66053
chore: Formatting
rschristian Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"envinfo": "^7.8.1",
"esm": "^3.2.25",
"file-loader": "^6.2.0",
"fork-ts-checker-webpack-plugin": "^4.0.4",
"fork-ts-checker-webpack-plugin": "^6.5.3",
rschristian marked this conversation as resolved.
Show resolved Hide resolved
"get-port": "^5.0.0",
"gittar": "^0.1.0",
"glob": "^8.0.3",
Expand Down
10 changes: 4 additions & 6 deletions packages/cli/src/lib/webpack/webpack-base-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,10 @@ module.exports = function createBaseConfig(env) {
}),
...(tsconfig
? [
new ForkTsCheckerWebpackPlugin({
checkSyntacticErrors: true,
async: !isProd,
tsconfig: tsconfig,
silent: !isWatch,
}),
new ForkTsCheckerWebpackPlugin({
typescript: {configFile: tsconfig, diagnosticOptions: {semantic: true, syntactic: true} },
rschristian marked this conversation as resolved.
Show resolved Hide resolved
async: !isProd
}),
]
: []),
...(isProd
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/lib/webpack/webpack-client-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function getBabelEsmPlugin(env) {
new BabelEsmPlugin({
filename: env.isProd ? '[name].[chunkhash:5].esm.js' : '[name].esm.js',
chunkFilename: '[name].chunk.[chunkhash:5].esm.js',
excludedPlugins: ['BabelEsmPlugin', 'InjectManifest'],
excludedPlugins: ['BabelEsmPlugin', 'InjectManifest', 'ForkTsCheckerWebpackPlugin'],
beforeStartExecution: plugins => {
plugins.forEach(plugin => {
if (
Expand Down
Loading